feat(docker): Custom port in .env #388
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnesetzer
commented
Aug 7, 2025
| container_name: pelias_libpostal | ||
| user: "${DOCKER_USER}" | ||
| restart: always | ||
| ports: [ "127.0.0.1:${PELIAS_LIBPOSTAL_PORT:-4400}:4400" ] |
Contributor
Author
There was a problem hiding this comment.
Since libpostal won't provide a custom port configuration inside the container it stays on 4400 internally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 I did some awesome work for the Pelias project and would love for everyone to have a look at it and provide feedback.
Here's the reason for this change 🚀
As mentioned in #253 custom port bindings in the .env would be nice in case the machine handles multiple geocoder instances. This PR is based on #386 since I was lazy and don't want to edit all compose files if there is a good chance that the PR will get merged first.
Here's what actually got changed 👏
Every .env file get the new variables set to the default ports. If the ports are not set the docker-compose.yml will use the default ones as well.
Here's how others can test the changes 👀
pelias compose ps