platsch.bbclass: add conversion to XRGB8888 format #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ulrich Ölmann <[email protected]>
Contributor
Author
|
Note: this can also be cherry-picked cleanly to styhead, scarthgap, nanbield and mickledore as well. |
lynxeye-dev
reviewed
Nov 21, 2024
| # HACK: a quite compact way to create a bitmap in the XRGB8888 format is to | ||
| # let ImageMagick convert the source into its known BMP subtype XRGB8888 and | ||
| # to strip the BMP header by only using the final width * height * (8+8+8+8)/8 | ||
| # bytes. For the i.MX6/i.MX8 the bitmap needs to be flipped (see [1]). This |
There was a problem hiding this comment.
There is nothing i.MX6/8 specific here. Platsch expects the image to be top-down, as that's the natural order you would fill a dumb BO to back the DRM FB.
Member
|
How should we proceed here? I can remember we had an internal discussion about whether these conversations should actually be part of a class, handled by a script, or just done once and placed in the BSP as files in the appropriate format. I'd be happy with any of the solutions, I guess. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a similar command line as for RGB565, we can also generate XRGB8888 formats.
Patch by @OnkelUlla, tested by me.
(Originally I wanted to literalize this generation a bit and make use of ImageMagick's RGBA output format followed by a simple reordering of the color channels with the
-color-matrixoption as mentioned in this discussion, but then the image is always written top-down and the-flipoption that we pass by default via${SPLASH_MGK_CUSTOM_OPTION}would be broken. So I opted for Ulrich's solution for now.)