umpf: highlight default choice in lists #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When showing a list of options, it is useful to have the default choice highlighted. So push the choices into variables and print them from function when the default choice is known. Then, print the default choice in bold. Signed-off-by: Benjamin Berg <[email protected]>
michaelolbrich
requested changes
Oct 17, 2025
| } | ||
|
|
||
| print_choices() { | ||
| local i default choice |
| fi | ||
| local i=0 def=0 choice | ||
| # shellcheck disable=SC2034 | ||
| local -a choices choices_descs |
There was a problem hiding this comment.
While you can declare local variable in the middle of a function inside a loop, they will not actually go out of scope at the end of the loop body.
So if the user gives an invalid response, all the choices are shown twice.
You need to explicitly initialize the variables, e.g. choices=()
| while [ -z "${topic}" ]; do | ||
| local i=0 choice default | ||
| # shellcheck disable=SC2034 | ||
| local -a choices choice_descs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When showing a list of options, it is useful to have the default choice highlighted. So push the choices into variables and print them from function when the default choice is known. Then, print the default choice in bold.
I think this is may be a nice touch for the UI.