Skip to content

K8SPSMDB-1339: add validation to .spec.pitr.date #2039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Sep 16, 2025
Merged

K8SPSMDB-1339: add validation to .spec.pitr.date #2039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
4ad9a6a
K8SPSMDB-1339: add validation to `.spec.pitr.date`
pooknull Sep 9, 2025
7a0fc97
add unit-test
pooknull Sep 10, 2025
b620e41
update ginkgo version
pooknull Sep 11, 2025
a0e39df
Merge remote-tracking branch 'origin/main' into K8SPSMDB-1339
pooknull Sep 11, 2025
75ffa61
Merge branch 'main' into K8SPSMDB-1339
hors Sep 12, 2025
edbfa77
update go ver to 1.25
pooknull Sep 12, 2025
1830572
Merge remote-tracking branch 'origin/main' into K8SPSMDB-1339
pooknull Sep 15, 2025
e8e1778
Merge remote-tracking branch 'origin/main' into K8SPSMDB-1339
pooknull Sep 15, 2025
a339102
update tools
pooknull Sep 15, 2025
da5d3a2
update test workflow
pooknull Sep 15, 2025
092ce63
fix
pooknull Sep 15, 2025
368d0b2
update controller-gen
pooknull Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/reviewdog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
- uses: actions/checkout@v5
- uses: actions/setup-go@v5
with:
go-version: '^1.24'
go-version: '^1.25'
- run: go install -v github.com/incu6us/goimports-reviser/v3@latest
- run: $(go env GOPATH)/bin/goimports-reviser -imports-order "std,general,company,project" -company-prefixes "github.com/percona" ./...
- uses: reviewdog/[email protected]
Expand All @@ -44,7 +44,7 @@ jobs:
- uses: actions/checkout@v5
- uses: actions/setup-go@v5
with:
go-version: '^1.24'
go-version: '^1.25'
- run: go install mvdan.cc/sh/v3/cmd/shfmt@latest
- run: $(go env GOPATH)/bin/shfmt -f . | grep -v 'vendor' | xargs $(go env GOPATH)/bin/shfmt -bn -ci -s -w
- name: suggester / shfmt
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ jobs:
name: Test
runs-on: ubuntu-latest
steps:
- uses: actions/setup-go@v5
with:
go-version: '^1.24'
- uses: actions/checkout@v5
- uses: actions/setup-go@v6
with:
go-version-file: go.mod
- name: run tests
run: make test
4 changes: 2 additions & 2 deletions Jenkinsfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,7 +447,7 @@ pipeline {
-v $WORKSPACE/src/github.com/percona/percona-server-mongodb-operator:/go/src/github.com/percona/percona-server-mongodb-operator \
-w /go/src/github.com/percona/percona-server-mongodb-operator \
-e GOFLAGS='-buildvcs=false' \
golang:1.24 sh -c '
golang:1.25 sh -c '
go install github.com/google/[email protected];
/go/bin/go-licenses csv github.com/percona/percona-server-mongodb-operator/cmd/manager \
| cut -d , -f 3 \
Expand Down Expand Up @@ -475,7 +475,7 @@ pipeline {
-v $WORKSPACE/src/github.com/percona/percona-server-mongodb-operator:/go/src/github.com/percona/percona-server-mongodb-operator \
-w /go/src/github.com/percona/percona-server-mongodb-operator \
-e GOFLAGS='-buildvcs=false' \
golang:1.24 sh -c 'go build -v -o percona-server-mongodb-operator github.com/percona/percona-server-mongodb-operator/cmd/manager'
golang:1.25 sh -c 'go build -v -o percona-server-mongodb-operator github.com/percona/percona-server-mongodb-operator/cmd/manager'
"
'''

Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ endef

CONTROLLER_GEN = $(shell pwd)/bin/controller-gen
controller-gen: ## Download controller-gen locally if necessary.
$(call go-get-tool,$(CONTROLLER_GEN),sigs.k8s.io/controller-tools/cmd/controller-gen@v0.16.3)
$(call go-get-tool,$(CONTROLLER_GEN),sigs.k8s.io/controller-tools/cmd/controller-gen@v0.19.0)

KUSTOMIZE = $(shell pwd)/bin/kustomize
kustomize: ## Download kustomize locally if necessary.
Expand Down
2 changes: 1 addition & 1 deletion build/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM --platform=${BUILDPLATFORM} golang:1.24 AS go_builder
FROM --platform=${BUILDPLATFORM} golang:1.25 AS go_builder
WORKDIR /go/src/github.com/percona/percona-server-mongodb-operator

COPY go.mod go.sum ./
Expand Down
2 changes: 1 addition & 1 deletion config/crd/bases/psmdb.percona.com_perconaservermongodbbackups.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.3
controller-gen.kubebuilder.io/version: v0.19.0
name: perconaservermongodbbackups.psmdb.percona.com
spec:
group: psmdb.percona.com
Expand Down
8 changes: 7 additions & 1 deletion config/crd/bases/psmdb.percona.com_perconaservermongodbrestores.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.3
controller-gen.kubebuilder.io/version: v0.19.0
name: perconaservermongodbrestores.psmdb.percona.com
spec:
group: psmdb.percona.com
Expand Down Expand Up @@ -191,6 +191,12 @@ spec:
type:
type: string
type: object
x-kubernetes-validations:
- message: Time should be in format YYYY-MM-DD HH:MM:SS
rule: self.type != 'date' || (has(self.date) && self.date.matches('^[0-9]{4}-[0-9]{2}-[0-9]{2}
[0-9]{2}:[0-9]{2}:[0-9]{2}$'))
- message: Date should not be used when 'latest' type is used
rule: self.type != 'latest' || !has(self.date)
replset:
type: string
selective:
Expand Down
2 changes: 1 addition & 1 deletion config/crd/bases/psmdb.percona.com_perconaservermongodbs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.3
controller-gen.kubebuilder.io/version: v0.19.0
name: perconaservermongodbs.psmdb.percona.com
spec:
group: psmdb.percona.com
Expand Down
12 changes: 9 additions & 3 deletions deploy/bundle.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.3
controller-gen.kubebuilder.io/version: v0.19.0
labels:
app.kubernetes.io/component: crd
app.kubernetes.io/name: percona-server-mongodb
Expand Down Expand Up @@ -233,7 +233,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.3
controller-gen.kubebuilder.io/version: v0.19.0
labels:
app.kubernetes.io/component: crd
app.kubernetes.io/name: percona-server-mongodb
Expand Down Expand Up @@ -426,6 +426,12 @@ spec:
type:
type: string
type: object
x-kubernetes-validations:
- message: Time should be in format YYYY-MM-DD HH:MM:SS
rule: self.type != 'date' || (has(self.date) && self.date.matches('^[0-9]{4}-[0-9]{2}-[0-9]{2}
[0-9]{2}:[0-9]{2}:[0-9]{2}$'))
- message: Date should not be used when 'latest' type is used
rule: self.type != 'latest' || !has(self.date)
replset:
type: string
selective:
Expand Down Expand Up @@ -467,7 +473,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.3
controller-gen.kubebuilder.io/version: v0.19.0
labels:
app.kubernetes.io/component: crd
app.kubernetes.io/name: percona-server-mongodb
Expand Down
12 changes: 9 additions & 3 deletions deploy/crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.3
controller-gen.kubebuilder.io/version: v0.19.0
labels:
app.kubernetes.io/component: crd
app.kubernetes.io/name: percona-server-mongodb
Expand Down Expand Up @@ -233,7 +233,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.3
controller-gen.kubebuilder.io/version: v0.19.0
labels:
app.kubernetes.io/component: crd
app.kubernetes.io/name: percona-server-mongodb
Expand Down Expand Up @@ -426,6 +426,12 @@ spec:
type:
type: string
type: object
x-kubernetes-validations:
- message: Time should be in format YYYY-MM-DD HH:MM:SS
rule: self.type != 'date' || (has(self.date) && self.date.matches('^[0-9]{4}-[0-9]{2}-[0-9]{2}
[0-9]{2}:[0-9]{2}:[0-9]{2}$'))
- message: Date should not be used when 'latest' type is used
rule: self.type != 'latest' || !has(self.date)
replset:
type: string
selective:
Expand Down Expand Up @@ -467,7 +473,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.3
controller-gen.kubebuilder.io/version: v0.19.0
labels:
app.kubernetes.io/component: crd
app.kubernetes.io/name: percona-server-mongodb
Expand Down
12 changes: 9 additions & 3 deletions deploy/cw-bundle.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.3
controller-gen.kubebuilder.io/version: v0.19.0
labels:
app.kubernetes.io/component: crd
app.kubernetes.io/name: percona-server-mongodb
Expand Down Expand Up @@ -233,7 +233,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.3
controller-gen.kubebuilder.io/version: v0.19.0
labels:
app.kubernetes.io/component: crd
app.kubernetes.io/name: percona-server-mongodb
Expand Down Expand Up @@ -426,6 +426,12 @@ spec:
type:
type: string
type: object
x-kubernetes-validations:
- message: Time should be in format YYYY-MM-DD HH:MM:SS
rule: self.type != 'date' || (has(self.date) && self.date.matches('^[0-9]{4}-[0-9]{2}-[0-9]{2}
[0-9]{2}:[0-9]{2}:[0-9]{2}$'))
- message: Date should not be used when 'latest' type is used
rule: self.type != 'latest' || !has(self.date)
replset:
type: string
selective:
Expand Down Expand Up @@ -467,7 +473,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.3
controller-gen.kubebuilder.io/version: v0.19.0
labels:
app.kubernetes.io/component: crd
app.kubernetes.io/name: percona-server-mongodb
Expand Down
12 changes: 9 additions & 3 deletions e2e-tests/version-service/conf/crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.3
controller-gen.kubebuilder.io/version: v0.19.0
labels:
app.kubernetes.io/component: crd
app.kubernetes.io/name: percona-server-mongodb
Expand Down Expand Up @@ -233,7 +233,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.3
controller-gen.kubebuilder.io/version: v0.19.0
labels:
app.kubernetes.io/component: crd
app.kubernetes.io/name: percona-server-mongodb
Expand Down Expand Up @@ -426,6 +426,12 @@ spec:
type:
type: string
type: object
x-kubernetes-validations:
- message: Time should be in format YYYY-MM-DD HH:MM:SS
rule: self.type != 'date' || (has(self.date) && self.date.matches('^[0-9]{4}-[0-9]{2}-[0-9]{2}
[0-9]{2}:[0-9]{2}:[0-9]{2}$'))
- message: Date should not be used when 'latest' type is used
rule: self.type != 'latest' || !has(self.date)
replset:
type: string
selective:
Expand Down Expand Up @@ -467,7 +473,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.16.3
controller-gen.kubebuilder.io/version: v0.19.0
labels:
app.kubernetes.io/component: crd
app.kubernetes.io/name: percona-server-mongodb
Expand Down
Loading
Loading