K8SPXC-1568: prevent having * prefix in proxyadmin password
#2124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egegunes
reviewed
Nov 4, 2025
pkg/controller/pxc/secrets.go
Outdated
| // generatePass generates a random password of length passwordLen. | ||
| // The optional rules parameter expects usernames and adjusts the | ||
| // password generation logic based on them. | ||
| func generatePass(rules ...string) ([]byte, error) { |
Contributor
There was a problem hiding this comment.
isn't rules ...string a bit confusing if we just passing usernames?
12 tasks
egegunes
previously approved these changes
Nov 11, 2025
nmarukovich
reviewed
Nov 12, 2025
| return nil, errors.Wrap(err, "get rand int") | ||
| } | ||
| b[i] = passSymbols[randInt.Int64()] | ||
| } |
Contributor
There was a problem hiding this comment.
Why we use passSymbols here? Should we use symbols instead?
nmarukovich
previously approved these changes
Nov 13, 2025
gkech
reviewed
Nov 13, 2025
pkg/controller/pxc/secrets_test.go
Outdated
| t.Fatal(err) | ||
| } | ||
| if !strings.HasPrefix(string(p), "*") { | ||
| t.Fatal("expected '*' prefix when no rules are applied to the password") |
Contributor
There was a problem hiding this comment.
Why dont we use assert and require for ensuring that we have the expected results?
pkg/controller/pxc/secrets.go
Outdated
| // generatePass generates a random password of length passwordLen. | ||
| // The optional rules parameter expects usernames and adjusts the | ||
| // password generation logic based on them. | ||
| func generatePass(usernames ...string) ([]byte, error) { |
Contributor
There was a problem hiding this comment.
Why usernames is not username? We are passing a single user.
pkg/controller/pxc/secrets.go
Outdated
|
|
||
| for i := range passwordLen { | ||
| symbols := passSymbols | ||
| if slices.Contains(usernames, users.ProxyAdmin) { |
Contributor
There was a problem hiding this comment.
We can determine if we are proxyadmin by running simply something like this, correct?
len(username) > 0 && username[0] == users.ProxyAdmin
Contributor
There was a problem hiding this comment.
Also this can be pre calculated insteda of resolving it for every len(passwordLen) iteration
pkg/controller/pxc/secrets.go
Outdated
Comment on lines
117
to
120
| symbols = strings.ReplaceAll(symbols, "*", "") | ||
| } | ||
| symbols = strings.ReplaceAll(symbols, ":", "") | ||
| symbols = strings.ReplaceAll(symbols, ";", "") |
Contributor
There was a problem hiding this comment.
I also think these can be precalculated in general
e.g.
firstCharSymbols = excludeChars(passSymbols, "*:;")
otherSymbols = excludeChars(passSymbols, ":;")
egegunes
previously approved these changes
Nov 17, 2025
gkech
previously approved these changes
Nov 19, 2025
gkech
approved these changes
Nov 24, 2025
hors
approved these changes
Nov 24, 2025
Collaborator
commit: f48cc30 |
egegunes
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/K8SPXC-1568
DESCRIPTION
It's not possible to use a
proxyadminpassword, which starts with*char.This PR ensures the operator generates
proxyadminpassword that do not begin with*.CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
compare/*-oc.yml)?Config/Logging/Testability