-
Notifications
You must be signed in to change notification settings - Fork 202
K8SPXC-1332 | Allow specifying caBundle for backup storage connection #2213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
|
ok, let's wait for test results |
Signed-off-by: Mayank Shah <[email protected]>
|
@egegunes the test fails in the |
|
@mayankshah1607 tests are run in cluster wide mode on jenkins. you can run the test with cluster wide by setting |
Signed-off-by: Mayank Shah <[email protected]>
| sed "s/#namespace/$namespace/g" $test_dir/conf/cert.yml | | ||
| kubectl_bin apply -f "-" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[shfmt] reported by reviewdog 🐶
| sed "s/#namespace/$namespace/g" $test_dir/conf/cert.yml | | |
| kubectl_bin apply -f "-" | |
| sed "s/#namespace/$namespace/g" $test_dir/conf/cert.yml \ | |
| | kubectl_bin apply -f "-" |
| sed "s/#namespace/$namespace/g" $test_dir/conf/cert.yml | | ||
| kubectl_bin apply -f "-" | ||
| sleep 30 # wait for the certificates to be issued | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[shfmt] reported by reviewdog 🐶
| minio_cert_secret="minio-tls-certs" | ||
| start_minio "$minio_cert_secret" | ||
| cluster="test-cluster" | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[shfmt] reported by reviewdog 🐶
| spinup_pxc "$cluster" "$test_dir/conf/$cluster.yml" | ||
|
|
||
| write_test_data "$cluster" | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[shfmt] reported by reviewdog 🐶
hors
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mayankshah1607, please add these new options as a comment in deploy/cr.yaml file
# caBundle:
# name: minio-ca-bundle
# key: tls.crt
@mayankshah1607 Did you create a PR for the Helm chart?
| AWS_S3_NO_VERIFY_SSL='--no-verify-ssl' | ||
| fi | ||
|
|
||
| caBundleDir="/etc/s3/certs" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope it will work for OpenShift
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tried, but why won't it?
Signed-off-by: Mayank Shah <[email protected]>
|
@hors helm chart PR, please review - percona/percona-helm-charts#688 |
Signed-off-by: Mayank Shah <[email protected]>
commit: f9b155d |
CHANGE DESCRIPTION
Problem:
Backups and restores against S3 endpoints served over HTTPS with private/internal certificates fail unless TLS verification is disabled, which weakens security by forcing verifyTLS=false and bypassing server identity checks.
Solution:
Introduce a configurable
caBundlefor S3 storage so clients can verify TLS using a trusted CA without disabling SSL verification.Example backup storage
CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
compare/*-oc.yml)?Config/Logging/Testability