Skip to content

Conversation

@ademidoff
Copy link
Member

@ademidoff ademidoff commented Nov 22, 2025

PMM-4326

Link to the Feature Build: SUBMODULES-4123

Refactored the Register*HandlerFromEndpoint to use a shared connection.

Changes made:

  • Created a shared gRPC connection before registering handlers
  • The services register now via Register*Handler instead of Register*HandlerFromEndpoint
  • Added proper cleanup - the connection closes when the context is done (matching the pattern from Register*HandlerFromEndpoint)

All services now use a shared connection. The connection is created once and reused, avoiding the extra dials for every other service.

@codecov
Copy link

codecov bot commented Nov 22, 2025

Codecov Report

❌ Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.74%. Comparing base (c92fe2d) to head (ad34459).
⚠️ Report is 2 commits behind head on v3.

Files with missing lines Patch % Lines
managed/cmd/pmm-managed/main.go 0.00% 25 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v3    #4770      +/-   ##
==========================================
+ Coverage   45.68%   45.74%   +0.06%     
==========================================
  Files         364      364              
  Lines       37759    37747      -12     
==========================================
+ Hits        17249    17267      +18     
+ Misses      18851    18825      -26     
+ Partials     1659     1655       -4     
Flag Coverage Δ
managed 46.21% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ademidoff ademidoff marked this pull request as ready for review November 22, 2025 17:45
@ademidoff ademidoff requested a review from a team as a code owner November 22, 2025 17:45
@ademidoff ademidoff requested review from BupycHuk and idoqo and removed request for a team November 22, 2025 17:45
@ademidoff ademidoff merged commit 5ddc655 into v3 Nov 28, 2025
14 checks passed
@ademidoff ademidoff deleted the PMM-4326-shared-grpc-connection branch November 28, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants