partial revert of 89132fb9 to maintain java 8 compatibility #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…EADME/RELEASE documents consistent
|
I have a suite of integration tests I ran my locally compiled version of this client with to success, I didn't see any. documentation on how to test this otherwise. |
|
Hey @ajindal-mdx and @skumar7322 , you two seem to be regular committers to perforce/p4java. Mind giving this simple/tiny build.gradle revert a review/merge and cutting a release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
README.md states:
Yet, as of 89132fb RELEASE.md says JDK 11 is required. The code is all JDK 8 compatible, and many vendors like Azul still support JDK 8 through 2030, so maintaining this support would likely help this project's adoption.