fix 779 issus #782
Open
fix 779 issus #782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reason for the change: Based on the issue: permissions-dispatcher#779 Bug reason: When upgrading Kotlin or base library versions, some libraries that use KotlinPoet may also be upgraded to version 1.11 or higher. KotlinPoet 1.11.0 has the following release note: • Fix: Enforce only allowed parameter modifiers in ParameterSpec (i.e. crossinline, vararg, and noinline). For more details, please refer to: https://github.com/square/kotlinpoet/releases When generating the PermissionRequest class for methods annotated with @NeedsPermission, the private constructor will cause an error. Reproduction steps: Upgrade KotlinPoet to 1.11.0 Add a new parameter "callback" to the MainActivity#showCamera method in the sample Modification: Do not pass the KModifier.*PRIVATE parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for the change:
Based on the issue: #779
Bug reason:
When upgrading Kotlin or base library versions, some libraries that use KotlinPoet may also be upgraded to version 1.11 or higher.
KotlinPoet 1.11.0 has the following release note:
• Fix: Enforce only allowed parameter modifiers in ParameterSpec (i.e. crossinline, vararg, and noinline).
For more details, please refer to: https://github.com/square/kotlinpoet/releases
When generating the PermissionRequest class for methods annotated with @NeedsPermission, the private constructor will cause an error.
Reproduction steps:
Upgrade KotlinPoet to 1.11.0
Add a new parameter "callback" to the MainActivity#showCamera method in the sample Modification:
Do not pass the KModifier.*PRIVATE parameter