Skip to content

Adding BeamNG example #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Adding BeamNG example #3

wants to merge 4 commits into from

Conversation

sidtalia
Copy link
Collaborator

Adding a BeamNG in-the-loop example.

This example is a bit heavy on the dependencies, so I'm not expecting the PR to review whether it works; I've ensured on my end that if BeamNGRL is installed correctly and is on the right branch, then the example should work.

This example runs the planner in the background using torch multi-processing and allows the MPC and Planner to work asynchronously (as it would on a real system) while being run from the same Python script.

Places where feedback could be useful: is the README + code sufficiently clear on how someone would use the planner in the loop (if it had to be run from the same python script)? Do I need to explain parts of the code/places where comments would be useful.

Copy link
Collaborator

@rohanblueboybaijal rohanblueboybaijal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • termcolor error

  • scipy not found

  • psutil not found

  • The code does not seem to work on MacOS at the moment. It is unable to find the boost header library

  • (GENERAL CODE COMMENT / NOT SPECIFIC TO BEAMNG) I see some sys.append calls in the code. I think it is better practice to have the modules installed as part of the pyproject or setup.py. Try to avoid these workarounds for importing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants