-
-
Notifications
You must be signed in to change notification settings - Fork 78
Support a launch argument to configure the playwright binary location #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 4.x
Are you sure you want to change the base?
Conversation
|
I know this is super nitpicky, but in your comments you have it spelled "Playwrite" when it's actually spelled "Playwright" |
Ah not my finest! Resolved that this morning. |
|
@tommitchelmore, the tests are failing. Could you review and reopen. |
|
@jasonmccreary that's resolves now, apologies - I'd not clocked that. |
|
@jasonmccreary Going to double check my implementation.
|
|
@tommitchelmore, thanks. Looks like everything is in order now. I'm going to defer this to @nunomaduro though. The only note I have is that the custom exception is unnecessary code. Just throw a |
|
@jasonmccreary thank you for your time, much appreciated! I've just removed that exception. |
|
Just bumping this - having this feature merged would be a big help for us. |

Configurable Playwright Binary Location
Problem
We run a bespoke non-laravel project structure, and our frontend code lives in a nested directory.
We want to be able to specify the location of the Playwright Binary at launch, i.e.
I feel this is in a similar vein to #136 - supporting bespoke/non-standard Playwright set ups would be a great direction to go in.
Solution
In this PR I've added a static property to the
PlaywrightclassexecutablePaththat defaults to the current hard-coded string in 4.x.In
Plugin, I've added a section tohandleArgumentsthat handles a value passed to--playwright-path.In
ServerManager, I've replaced the hard-coded path string withPlaywright::executablePath().