Fix stopping playwright server #169
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run playwright without shell so that signals can be sent directly to the process.
If playwright is already defined, do not try to persist again with a new port
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pest completes, a terminate signal is sent to stop the playwright server. As it is run using a shell (by passing commandline as a string), the shell receives this signal, which it does not forward to playwright.
This means that the
playwright run-servercommand continues running after pest exits.Solution
Run playwright server command without shell (passing commandline as an array) so that signals can be sent directly to playwright to terminate it.
Related change
Avoid persisting a new port for
AlreadyStartedPlaywrightServerif playwright is already set.