Remove need for pcntl extension #172
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove need for ext-pcntl / ext-posix by using the default signals to stop playwright process. Default is to use SIGTERM, followed by a SIGKILL after the given timeout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #141 to fix running on a system that does not have
pcntlextension enabled.Solution
Stop passing
SIGTERM(defined inpcntlextension) toSymfony\Component\Process\Process->stop(), allowing it to use the default. This default behavior is to signal withSIGTERMand if the process fails to stop before the timeout, signal again withSIGKILL.I considered increasing the timeout to ensure playwright server has sufficient time to stop from the initial
SIGTERMsignal. My measurements show it stopping in under 1 millisecond so 0.1 seconds seems ample.