Support cookies and server variables in LaravelHttpServer #181
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within
handleRequest()$request->getCookies()returns an array ofAmp\Cookie\RequestCookieobjects. Before this PR those were being passed directly to the LaravelRequestclass, even though that expects an array of string key-value pairs.So we first map over the amp cookie objects and get them into the format Laravel expects. We have to call urldecode because the browser engines give amp encoded strings, but the laravel request expects decoded strings.
After that, we merge in any cookies set within the test cases.
The server variables is a little more straightforward. We create a method on the
Browsabletrait that gives us access to theprotected $serverVariablesproperty on theTestCase/MakesHttpRequests.