Skip to content

Conversation

@ycs77
Copy link
Contributor

@ycs77 ycs77 commented Aug 26, 2025

Added the Simplified Chinese and Traditional Chinese languages.

@ycs77 ycs77 marked this pull request as ready for review August 26, 2025 20:50
@ycs77 ycs77 changed the title lang: add chinese profanity Chinese profanity Aug 26, 2025
@JonPurvis
Copy link
Collaborator

Hey @ycs77

Thanks for the contribution! Would you mind taking a look at the failing test? We prefer config files to be in alphabetical order to make it easier to scan for words/phrases.

Once sorted, I'd be happy to merge this PR.

@faissaloux Will pest-plugin-inside work with Chinese characters?

@ycs77
Copy link
Contributor Author

ycs77 commented Sep 9, 2025

@JonPurvis done, the Chinese characters sorting is fixed!

@JonPurvis JonPurvis merged commit cebcba7 into pestphp:4.x Sep 9, 2025
14 checks passed
@JonPurvis
Copy link
Collaborator

Perfect, thanks very much @ycs77 🥳

@ycs77 ycs77 deleted the lang-zh branch September 9, 2025 19:45
@faissaloux
Copy link
Contributor

@faissaloux Will pest-plugin-inside work with Chinese characters?

I don't think Chinese has an alphabetical order 🤔

@JonPurvis
Copy link
Collaborator

Yeah all good, tests ended up passing 🥳

@faissaloux
Copy link
Contributor

Cool!

Not sure if it's alphabetical but good to have an order though.

@JonPurvis
Copy link
Collaborator

Yeah I just took the passing test as everything being ok 😆

@ycs77
Copy link
Contributor Author

ycs77 commented Sep 10, 2025

I'm just using the php sort() function to sort the Chinese array to fix the tests.

Seems the php sort() is sorting by Unicode? I'm not sure. 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants