fix: uses beforeAll not being called since 3.0.4 #1322
Closed
+29
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laylatichy
force-pushed
the
fix-before-all-call-setup-earlier
branch
from
6e52196 to
c045624
Compare
…rait setUp has to be called earlier for pest()->beforeAll to register closure fixes regression from 3.0.4
laylatichy
force-pushed
the
fix-before-all-call-setup-earlier
branch
from
c045624 to
6d805c8
Compare
…l hook fix: invalid assertion chore: update snapshot
laylatichy
force-pushed
the
fix-before-all-call-setup-earlier
branch
from
3668c93 to
665112c
Compare
Ehsan-hulle24
approved these changes
Mar 2, 2025
Member
|
this is fixed on 4.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Description:
fixes regresion from 3.0.4 that beforeAll hook from pest()/uses() is not called
moved TestCaseMethodFactory setUp method call back to testable constructor because calling it in setUp was already to late
Related:
#1282