-
Notifications
You must be signed in to change notification settings - Fork 3
Justfile and CI changes #701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
6c1b02a to
a2642fb
Compare
857c9c1 to
afe6086
Compare
1ab489a to
89467d0
Compare
a5b884e to
0a61855
Compare
383e3f1 to
20a4bd6
Compare
7b01427 to
3e464b3
Compare
3e464b3 to
1eec13e
Compare
| - name: Set up Rust toolchain | ||
| uses: dtolnay/[email protected] | ||
| - uses: Swatinem/rust-cache@v2 | ||
| - run: cargo build --verbose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed cargo build, because everything it does should be covered by other tests.
| CODE_SIGN_STYLE = Automatic; | ||
| COMBINE_HIDPI_IMAGES = YES; | ||
| DEVELOPMENT_TEAM = 7QXP938FNA; | ||
| DEVELOPMENT_TEAM = ""; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the signing key from debug builds. I hope that CI builds are still signed correctly.
| # | ||
| # SPDX-License-Identifier: AGPL-3.0-or-later | ||
|
|
||
| DATABASE_URL=sqlite:coreclient/client.db |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked in this file, because my IDE needs this. I think it's useful to have this as the default.
| cargo sqlx prepare --database-url sqlite://{{justfile_directory()}}/coreclient/client.db | ||
|
|
||
| # This task will run the command and hide stdout. If git diff then reports unstaged changes, the task will fail. | ||
| _check-unstaged-changes command: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like to disable stdout, so it's cleaner when used as a CLI. I can enable all logs in CI if we want.
kkohbrok
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I'd say we merge this for now and adjust what doesn't work in the next weeks.
|
One of the TODOs is still marked as not done, has that been addressed? |
5fba598 to
92c515a
Compare
92c515a to
637143e
Compare
6eb0e84 to
5e1160e
Compare
366ab89 to
ac6c0bd
Compare
ac6c0bd to
9264a61
Compare
TODOs:
Important changes:
Install these to run the whole CI locally:
Then run the CI with
just ciInstead of frb-generate you can use regenerate-frb
Instead of updating goldens with the CI, you can use
just update-flutter-goldensSimply type
justto see all commands: