Skip to content

Conversation

Arzaroth
Copy link

Following the discussion in #256.

This addresses #208.

@oscarotero
Copy link
Member

As commented in #256 (comment) I think this change introduces unnecessary complexity to the Code Scanner, because the function scanString() allows to achieve this.

In fact, scanFile() uses scanString() internally: https://github.com/php-gettext/Gettext/blob/master/src/Scanner/Scanner.php#L41

So I'm going to pause this for now.
Thanks, anyway!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants