Skip to content

ext/standard: handle html entities empty string before processing #19220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 28, 2025
+3 −0
Merged

ext/standard: handle html entities empty string before processing #19220

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e210de8
handle html entities empty string
xepozz Jul 23, 2025
a784b17
apply review suggestions
xepozz Jul 23, 2025
987f327
use empty string pointer
xepozz Jul 23, 2025
8cca28d
remove expectations
xepozz Jul 25, 2025
1615039
remove unnecessary return stmt
xepozz Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ext/standard/html.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1320,6 +1320,10 @@ static void php_html_entities(INTERNAL_FUNCTION_PARAMETERS, int all)
Z_PARAM_BOOL(double_encode);
ZEND_PARSE_PARAMETERS_END();

if (ZSTR_LEN(str) == 0) {
RETURN_EMPTY_STRING();
return;
}
replaced = php_escape_html_entities_ex(
(unsigned char*)ZSTR_VAL(str), ZSTR_LEN(str), all, (int) flags,
hint_charset ? ZSTR_VAL(hint_charset) : NULL, double_encode, /* quiet */ 0);
Expand Down