Add support for manually running the real-time benchmark on PRs #19265
+149
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kocsismate
force-pushed
the
benchmark-manual-workflow
branch
from
3de527f to
a233037
Compare
kocsismate
changed the title
kocsismate
force-pushed
the
benchmark-manual-workflow
branch
from
a233037 to
64751de
Compare
iluuu1994
reviewed
Jul 29, 2025
| required: true | ||
| type: string | ||
| commit: | ||
| description: 'Commit SHA that is going to be benchmarked (e.g. "123456789a")' |
There was a problem hiding this comment.
Why not just use ref and baseline_ref? This can be either a branch, tag, commit, etc.
| runs-on: ubuntu-22.04 | ||
| env: | ||
| REPOSITORY: ${{ inputs.repository || 'php/php-src' }} |
There was a problem hiding this comment.
These fallbacks seem useless if all inputs are required?
| fetch-depth: 100 | ||
| path: 'php-version-benchmarks/tmp/php_master' | ||
| path: 'php-version-benchmarks/tmp/php_${{ env.BRANCH }}' |
There was a problem hiding this comment.
Could probably drop the dynamic path suffix _${{ env.BRANCH }} here.
|
@iluuu1994 Thanks for looking into it! I have managed to start testing the manual workflow on my own repo. I implemented some fixes there, but unfortunately a separate issue (github rate limit) blocks it from finishing successfully, so I have to take care of this problem first. Afterwards, I'll update this PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't yet test it...