uri: Pass uri_object_t instead of zend_object where possible
#19854
+40
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimWolla
commented
Sep 15, 2025
| ZEND_ASSERT(base_url_object->ce == uri_object->std.ce); | ||
| uri_internal_t *internal_base_url = uri_internal_from_obj(base_url_object); | ||
| ZEND_ASSERT(base_url_object->std.ce == uri_object->std.ce); | ||
| const uri_internal_t *internal_base_url = &base_url_object->internal; |
There was a problem hiding this comment.
In this line making the change pointed out a const-correctness bug.
kocsismate
approved these changes
Sep 20, 2025
TimWolla
added a commit
to TimWolla/php-src
that referenced
this pull request
Sep 21, 2025
The functions derived non-const pointers from a const-pointer, which is not correct. Since php#19854 no `const` pointers are passed into these functions, so we can just make the parameter non-const.
TimWolla
added a commit
that referenced
this pull request
Sep 21, 2025
The functions derived non-const pointers from a const-pointer, which is not correct. Since #19854 no `const` pointers are passed into these functions, so we can just make the parameter non-const.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves type safety for the caller, since it is immediately visible what type of object is expected.