Reorganize ext/uri tests - equivalence #20391
Open
+540
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimWolla
reviewed
Nov 4, 2025
Member
TimWolla
left a comment
TimWolla
left a comment
There was a problem hiding this comment.
I have looked at all WHATWG tests.
| <?php | ||
|
|
||
| $url1 = new Uri\WhatWg\Url("https://example%2ecom:443"); | ||
| $url2 = new Uri\WhatWg\Url("https://example.com:0443"); |
Member
There was a problem hiding this comment.
There is also a port difference here.
| @@ -0,0 +1,15 @@ | |||
| --TEST-- | |||
| Test Uri\WhatWg\Url equivalence - returns true - path is not percent-decoded during normalization | |||
Member
There was a problem hiding this comment.
The description says "returns true".
| @@ -0,0 +1,15 @@ | |||
| --TEST-- | |||
| Test Uri\WhatWg\Url equivalence - returns false - fragment excluded | |||
Member
There was a problem hiding this comment.
The description and file name says "false", but the expectations say true.
Member
There was a problem hiding this comment.
This test is not really meaningful, because the difference is not in fragment, but in the path. So with either option of the comparison mode the result would be false.
I'm missing a test with the same URIs as ext/uri/tests/whatwg/equivalence/equals_true_exclude_fragment.phpt that uses IncludeFragment and then returns false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.