provide access to return_value, function's type, filename, line number #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When observing a function via observer API or zend_execute_*, these additional functions allow looking up the function's type and the filename (for user functions and eval'd code). From ExecuteData we can also retrieve the return value in a number of ways.
There was a problem hiding this comment.
Pull Request Overview
This pull request enhances the phper crate by adding utility methods to access function metadata and execution context information when working with PHP internals from Rust.
- Added function type and filename retrieval methods to
ZFunc - Added line number and return value access methods to
ExecuteData - Provided multiple variants for return value access (immutable, mutable, and raw pointers)
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| phper/src/functions.rs | Adds get_type() and get_filename() methods to ZFunc for retrieving function metadata |
| phper/src/values.rs | Adds get_lineno() and return value access methods to ExecuteData for execution context information |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
phper/src/functions.rs
Outdated
| /// Get the type of the function (ZEND_USER_FUNCTION, | ||
| /// ZEND_INTERNAL_FUNCTION, etc). | ||
| pub fn get_type(&self) -> u8 { | ||
| unsafe { self.inner.type_ } |
There was a problem hiding this comment.
[nitpick] Consider returning a more type-safe enum instead of a raw u8. This would make the API more self-documenting and prevent invalid function type values.
Suggested change
| unsafe { self.inner.type_ } | |
| pub fn get_type(&self) -> Option<FunctionType> { | |
| FunctionType::from_u8(unsafe { self.inner.type_ }) |
Copilot uses AI. Check for mistakes.
Co-authored-by: Copilot <[email protected]>
…xecute_data_retval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds new utility methods to the
ZFuncandExecuteDatastructs in thephpercrate, providing improved access to function metadata and execution context information. These additions make it easier to retrieve function types, filenames, line numbers, and return values when working with PHP internals from Rust.Function metadata access improvements:
get_typetoZFuncfor retrieving the function type (e.g.,ZEND_USER_FUNCTION,ZEND_INTERNAL_FUNCTION).get_filenametoZFuncto obtain the filename for user-defined or eval'd functions using theop_array.Execution context access improvements:
get_linenotoExecuteDatato retrieve the current source code line number for user or eval'd functions.get_return_value,get_return_value_mut,get_return_value_mut_ptr, andget_return_value_ptrtoExecuteDatafor accessing the return value in various forms (immutable, mutable, and raw pointers).