-
Notifications
You must be signed in to change notification settings - Fork 20
fix fpm setup on macos #218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
setup-php action already installs php-fpm in the expected location
This reverts commit 33728da.
I didn't remove the setup-fpm step for linux - although setup-php does install php-fpm, the tests failed and I didn't investigate further. Also note that the macos tests seem a bit flaky, I'm seeing lots of failures for the test http client reaching |
Maybe you can replace example.com with a more reliable website. |
I will try something tomorrow. example.com is probably the best choice for an external website, so I'll look at running a local webserver (eg php's cli-server). edit: updated to use cli-server, and everything is green now. |
Is there any update? |
No more updates, if you are happy with the use of built-in webserver to replace example.com |
Remove the "setup php-fpm" step for macos, since the setup-php step reliably installs php-fpm in a location found by the tests.
Replace
example.com
with a local cli-server endpoint, since macos builds were often failing to reach example.com