Skip to content

fix fpm setup on macos #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 22, 2025
Merged

Conversation

brettmc
Copy link
Contributor

@brettmc brettmc commented Aug 21, 2025

Remove the "setup php-fpm" step for macos, since the setup-php step reliably installs php-fpm in a location found by the tests.
Replace example.com with a local cli-server endpoint, since macos builds were often failing to reach example.com

@brettmc
Copy link
Contributor Author

brettmc commented Aug 21, 2025

I didn't remove the setup-fpm step for linux - although setup-php does install php-fpm, the tests failed and I didn't investigate further.

Also note that the macos tests seem a bit flaky, I'm seeing lots of failures for the test http client reaching example.com (which was briefly unreachable for me, and also according to https://downforeveryoneorjustme.com/example.com earlier today). macos seems particularly sensitive to it.

@brettmc brettmc marked this pull request as ready for review August 21, 2025 07:09
@jmjoy
Copy link
Member

jmjoy commented Aug 21, 2025

Maybe you can replace example.com with a more reliable website.

@brettmc
Copy link
Contributor Author

brettmc commented Aug 21, 2025

Maybe you can replace example.com with a more reliable website.

I will try something tomorrow. example.com is probably the best choice for an external website, so I'll look at running a local webserver (eg php's cli-server).

edit: updated to use cli-server, and everything is green now.

@jmjoy
Copy link
Member

jmjoy commented Aug 22, 2025

Is there any update?

@brettmc
Copy link
Contributor Author

brettmc commented Aug 22, 2025

Is there any update?

No more updates, if you are happy with the use of built-in webserver to replace example.com

@jmjoy jmjoy merged commit 7902372 into phper-framework:master Aug 22, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants