-
-
Notifications
You must be signed in to change notification settings - Fork 222
Update pihole.toml documentation #1258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for pihole-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
101b5a9
to
f5f4ccf
Compare
One of the linting rules is wrongly identifying 2 asterisks as italic markers. Since these asterisks are normal text (not used to format the text as Italic), they contain spaces around them and this is triggering the MD037 rule: This is the text. The highlighted part is not in italic, but the linter is throwing an error: format, and it must have both, private key and certificate (the *.pem file created must contain a 'CERTIFICATE' section as well as a 'RSA PRIVATE KEY' section). The *.pem file can be created using cp server.crt server.pem The same happens here, between the 2 Maybe we need to escape asterisks and underscores, or just disable rule MD037 for the file. |
f5f4ccf
to
4853202
Compare
Already identified and fixed - see latest commit :) |
f3d8b56
to
5653c48
Compare
This is not a big issue, but why is EDIT: I think I found the reason. Apparently the only difference between this "Possible values" section and the other sections is: The values here are not strings (the values are not inside quotes): |
5653c48
to
6a67c00
Compare
I also noticed the AI removed the code for escape angled brackets, resulting in missing text: This: # Possible values are:
# <any valid domain> Was printed just as:
The text between |
7e59503
to
580b626
Compare
580b626
to
7fc9444
Compare
Automated PR to update pihole.toml documentation from FTL build.