Skip to content

Update pihole.toml documentation #1258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pralor-bot
Copy link
Collaborator

Automated PR to update pihole.toml documentation from FTL build.

@pralor-bot pralor-bot requested a review from a team as a code owner July 2, 2025 22:10
Copy link

netlify bot commented Jul 2, 2025

Deploy Preview for pihole-docs ready!

Name Link
🔨 Latest commit 7fc9444
🔍 Latest deploy log https://app.netlify.com/projects/pihole-docs/deploys/686923240d89e500084f0518
😎 Deploy Preview https://deploy-preview-1258--pihole-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pralor-bot pralor-bot force-pushed the update-pihole-toml-docs branch 4 times, most recently from 101b5a9 to f5f4ccf Compare July 3, 2025 12:08
@rdwebdesign
Copy link
Member

@PromoFaux

One of the linting rules is wrongly identifying 2 asterisks as italic markers.

image

Since these asterisks are normal text (not used to format the text as Italic), they contain spaces around them and this is triggering the MD037 rule:

This is the text. The highlighted part is not in italic, but the linter is throwing an error:

format, and it must have both, private key and certificate (the *.pem file created must contain a 'CERTIFICATE' section as well as a 'RSA PRIVATE KEY' section). The *.pem file can be created using cp server.crt server.pem

The same happens here, between the 2 _esni (lines 69 and 78).

Maybe we need to escape asterisks and underscores, or just disable rule MD037 for the file.

@pralor-bot pralor-bot force-pushed the update-pihole-toml-docs branch from f5f4ccf to 4853202 Compare July 3, 2025 16:27
@PromoFaux
Copy link
Member

Already identified and fixed - see latest commit :)

@rdwebdesign
Copy link
Member

rdwebdesign commented Jul 4, 2025

This is not a big issue, but why is privacylevel not using table format?

image

EDIT:

I think I found the reason.

Apparently the only difference between this "Possible values" section and the other sections is: The values here are not strings (the values are not inside quotes):

  • privacylevel is configured as integer (no quotes):

    image

  • other options are configured as strings (quotes):

    image

@pralor-bot pralor-bot force-pushed the update-pihole-toml-docs branch from 5653c48 to 6a67c00 Compare July 4, 2025 02:05
@rdwebdesign
Copy link
Member

I also noticed the AI removed the code for escape angled brackets, resulting in missing text:

This:

  # Possible values are:
  #     <any valid domain>

Was printed just as:

Possible values are:

The text between < and > were considered a HTML tag an not printed.

@pralor-bot pralor-bot force-pushed the update-pihole-toml-docs branch 3 times, most recently from 7e59503 to 580b626 Compare July 5, 2025 05:02
@pralor-bot pralor-bot force-pushed the update-pihole-toml-docs branch from 580b626 to 7fc9444 Compare July 5, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants