Bugfix: Asset Numeric IN Filtering #1020
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When filtering assets, specifically numeric fields like
id, the values were not being applied with the IN filter in the query. This makes it so users could not filter by multiple asset ids like they could with data objects.When filtering via numeric values, it now checks if its a
infilter operator, then attempts to check to see if the value is already an array. If not, it uses similar logic to data object numeric parsing to split on all non-numeric values to get an array. Also added a cast on thedb->quotevalue to make sure all values are strings.