Upgrade PHPSpreadsheet to version ^5.1 #997
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
|
I have read the CLA Document and I hereby sign the CLA |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PHPSpreadsheet files used within the admin bundle are:
PhpOffice\PhpSpreadsheet\Reader\Csv
PhpOffice\PhpSpreadsheet\Writer\Exception
PhpOffice\PhpSpreadsheet\Writer\Xlsx
I've compared the diff between version 3.10.1 (as would be used with the ^3.3 set in the current composer.json) against the latest PHPSpreadsheet version 5.1.0, found here:
https://github.com/PHPOffice/PhpSpreadsheet/compare/3.10.1...5.1.0?diff=split
I did not see any changes that would affect the function calls used here:
https://github.com/pimcore/admin-ui-classic-bundle/blob/v2.1.3/src/Helper/GridHelperService.php#L949
PHPSpreadsheet's minimum PHP version is ^8.1 as set in their composer:
https://github.com/PHPOffice/PhpSpreadsheet/blob/5.1.0/composer.json#L69
Where the current admin bundle's PHP version is set to ~8.3.0 || ~8.4.0, which is compatible.
I have not tested this update, but I do not see why PHPSpreadsheet shouldn't be updated.