Implemented notification recipients endpoint #2103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Corepex
deleted the
1578-notifications-respect-permission-for-recipients
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Resolves #1578
Related to: pimcore/studio-backend-bundle#1402
Additional info
This pull request refactors the notification sending modal by extracting the notification form logic into a dedicated, reusable
NotificationFormcomponent. This improves code organization and maintainability, and introduces a newUserSelectcomponent for recipient selection.Component extraction and code organization:
NotificationFormcomponent innotification-form.tsx, moving all form fields and logic out of the modal file for better separation of concerns.send-notification-modal.tsxto use the newNotificationFormcomponent, removing inline form field definitions and related imports. [1] [2]New reusable components:
UserSelectcomponent inuser-select.tsxthat fetches recipient data and displays it in a select dropdown, improving reusability and encapsulation of recipient selection logic.These changes make the notification modal easier to maintain and extend in the future.