[Grid][Filter] - dont send "locale" in API call when column is not localizable #2107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
markus-moser
approved these changes
Sep 29, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Resolves #1570
Additional info
This pull request primarily updates the build output for the Pimcore Studio UI bundle, reflecting a new build version and improving filter logic in the data layer. The most important changes include updating build artifacts to use a new build hash, renaming and updating manifest and stats files, and refining locale and filter type handling in the general filters decorator.
Data layer improvements
withGeneralFiltersQueryArgdecorator now uses helper functions to determine the correct locale for each column and to resolve filter types, improving accuracy in filter application and localization support.Let me know if you have questions about how these changes affect filtering!