Skip to content

Conversation

@sukunrt
Copy link
Member

@sukunrt sukunrt commented Apr 1, 2024

This PR introduces a received chunk tracker.

  1. This is optimized for handling incoming chunks and reporting ACK Ranges by doing a sorted insert in received ACK ranges as opposed to sorting the whole list after insert.
  2. This removes the reference to the data chunk so that it could be garbage collected quicker.

@codecov
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 88.59649% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 81.21%. Comparing base (f0386f2) to head (c57fa56).

Files Patch % Lines
received_chunk_tracker.go 87.37% 11 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #319      +/-   ##
==========================================
+ Coverage   81.13%   81.21%   +0.07%     
==========================================
  Files          49       50       +1     
  Lines        4188     4285      +97     
==========================================
+ Hits         3398     3480      +82     
- Misses        647      664      +17     
+ Partials      143      141       -2     
Flag Coverage Δ
go 81.21% <88.59%> (+0.07%) ⬆️
wasm 67.42% <82.45%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edaniels
Copy link
Member

edaniels commented Apr 1, 2024

@sukunrt nice! As you get ready to put this up for review, could you share some performance testing you do/did with this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants