Update stream to RFC 9260 #411
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #411 +/- ##
==========================================
+ Coverage 83.84% 84.00% +0.16%
==========================================
Files 51 51
Lines 3448 3452 +4
==========================================
+ Hits 2891 2900 +9
+ Misses 417 414 -3
+ Partials 140 138 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates reliability parameter handling in SCTP streams and modernizes RFC references. The main changes include adding validation logic for reliability types and updating documentation to reference final RFCs instead of draft versions.
- Adds validation to
setReliabilityParamsto handle reliability types with fallback logic - Updates RFC references from draft versions to final published standards
- Fixes minor formatting issues in comments
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
philipch07
force-pushed
the
pch07/update-stream-to-9260
branch
from
0d8b0ca to
33f6628
Compare
philipch07
force-pushed
the
pch07/update-stream-to-9260
branch
from
33f6628 to
d0e129e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates stream.go to RFC 9260. Direct citations have been made for RFC 3758 and RFC 7496 for better documentation.
Reference issue
Resolves #410.