-
Notifications
You must be signed in to change notification settings - Fork 85
Add rack active RTT measurement #438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
philipch07
wants to merge
15
commits into
master
Choose a base branch
from
pch07/rack-active-rtt
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d607f9c.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #438 +/- ##
==========================================
+ Coverage 83.74% 84.32% +0.58%
==========================================
Files 51 52 +1
Lines 4527 4032 -495
==========================================
- Hits 3791 3400 -391
+ Misses 597 450 -147
- Partials 139 182 +43
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
According to https://duepublico2.uni-due.de/servlets/MCRFileNodeServlet/duepublico_derivate_00073893/Diss_Weinrank.pdf#page=113 section 7.3.2, an enhancement for RACK in SCTP is to add active RTT measurement.
This branch adds that feature. Note that it's built on the RACK branch merged with the adaptive burst mitigation branch.
The best thing to add after this would be the I bit as mentioned in 7.3.4 which is formalized in RFC 9260. That's something that will take place after all the 9260 prs go in, as it involves updating
Association.gowhich really needs a refactor since it's way too unwieldy...Reference issue
A RACK enhancement!