[Sqldef Pluging] refactor(sqldef) refactor sqldef toolRegistry download binary #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kadai0308 <[email protected]>
Signed-off-by: kadai0308 <[email protected]>
kadai0308
commented
Aug 13, 2025
| // Currently, we create them every time the stage is executed beucause we can't pass input.Client.toolRegistry to the plugin when starting the plugin. | ||
| toolRegistry := toolRegistryPkg.NewRegistry(input.Client.ToolRegistry()) | ||
|
|
||
| // map for prevent repeatedly download sqldef |
Contributor
Author
There was a problem hiding this comment.
I decided to keep it simple, just download the binary every time.
Signed-off-by: kadai0308 <[email protected]>
t-kikuc
reviewed
Aug 21, 2025
Comment on lines
+87
to
+88
| // For MySQL, verify the path contains the expected binary name | ||
| if tt.dbType == config.DBTypeMySQL { |
Member
There was a problem hiding this comment.
add a TODO comment to avoid missing when supporting other types.
| lp.Errorf("Failed while getting Sqldef tool (%v)", err) | ||
| return sdk.StageStatusFailure | ||
| } | ||
| lp.Info(fmt.Sprintf("Sqldef binary downloaded: %s", sqlDefPath)) |
Member
There was a problem hiding this comment.
the path is not necessary to show on UI
…ry_test Signed-off-by: kadai0308 <[email protected]>
kadai0308
changed the title
t-kikuc
approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
refactor sqldef toolRegistry download binary
Which issue(s) this PR fixes
Fixes #33 (comment)