-
Notifications
You must be signed in to change notification settings - Fork 208
ci: cancel in-progress test and lint workflows on new commits #6393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Ayush More <[email protected]>
6667d8f to
e87a93f
Compare
.github/workflows/test.yaml
Outdated
| - 'feat/*' | ||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ayushmore1214 Should we change this condition to ensure commit to master and release-* branches are already tested (no skip)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point — agreed 👍
.github/workflows/lint.yaml
Outdated
| - "feat/*" | ||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Ayush More <[email protected]>
Signed-off-by: Ayush More <[email protected]>
|
@khanhtc1202 made the changes ! |
What this PR does:
when new commits are pushed to the same branch or pull request.
Why we need it:
Which issue(s) this PR fixes:
Reduces unnecessary CI usage
Fixes CI: Cancel in-progress workflows on new commits to improve efficiency #6392
Does this PR introduce a user-facing change?:No