Skip to content

Conversation

@rahulshendre
Copy link

What this PR does:

File by file commit from the bigger PR - #6345

Adds the “Triggering a deployment” page under User Guide → Managing Application.

Related to #6395

Why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

@rahulshendre rahulshendre requested a review from a team as a code owner January 4, 2026 09:42
@rahulshendre
Copy link
Author

@eeshaanSA PTAL when you get a chance, and let me know if any changes are required.

Copy link
Contributor

@Ayushmore1214 Ayushmore1214 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rahulshendre the link for the screenshot of running deployment seems to be broken

@Ayushmore1214
Copy link
Contributor

Also your DCO seems to be failing , make sure to sign that off....

@rahulshendre rahulshendre force-pushed the userguide/managingApp/triggering-a-deployment branch from 74c2193 to 39fe99f Compare January 4, 2026 10:50
@rahulshendre
Copy link
Author

@rahulshendre the link for the screenshot of running deployment seems to be broken

@Ayushmore1214
Thanks for pointing this out. This is consistent with other already merged docs (e.g. #6378)
Images served from /static/images/ don’t render in GitHub’s markdown preview but do render correctly when the Hugo site is built and on the deployed docs.
I’ve verified this page locally, and the image renders as expected.

@eeshaanSA
Copy link
Contributor

@rahulshendre, I have left some suggestions and some comments, so you understand what kind of grammar changes I am looking for, and also understand how the language is supposed to be.

PTAL when you have time. :)

Signed-off-by: rahulshendre <[email protected]>
@rahulshendre
Copy link
Author

@rahulshendre, I have left some suggestions and some comments, so you understand what kind of grammar changes I am looking for, and also understand how the language is supposed to be.

Thanks for the suggestions @eeshaanSA
I’ve applied all the requested changes and improved the readability in the sections you mentioned.
I’ll follow the same language style and grammar for the remaining pages as well. PTAL : )

Copy link
Contributor

@eeshaanSA eeshaanSA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve earlier comments, commit the suggested changes, and improve the newer sections highlighted in this review. Thanks!

Signed-off-by: rahulshendre <[email protected]>
@rahulshendre
Copy link
Author

Addressed all the review comments and improved readability. PTAL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants