Update blogs' frontmatter URI to match the directory structure #360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dom Del Nano <[email protected]>
✅ Deploy Preview for blog-px-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ddelnano
changed the title
aimichelle
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Through the process of debugging why Hackernews posts are linking to the wrong post, I realized that the "eBPF TLS tracing: The Past, Present and Future" and "eBPF Probes and You: Navigating the kernel source for tracing" posts are one of the few posts that have their frontmatter inconsistent with the directory structure.
Our code seems to use the directory path as the URI (loading the blog posts confirms this), so the frontmatter is not used. While I don't have proof this is causing the strange Hackernews behavior, I do know that my "Keeping prod observable" post was posted properly. The pages I fixed in this PR had the incorrect meta tag issue as seen in the screenshots below: