Cache test data to be sent until WebSocket connection gets established #350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolandkakonyi
force-pushed
the
fix-socket-race-condition-with-too-quick-tests
branch
from
c4f4d01 to
f9a7147
Compare
rolandkakonyi
force-pushed
the
fix-socket-race-condition-with-too-quick-tests
branch
from
f9a7147 to
dbc8f8c
Compare
1 task
Contributor
|
Hi @rolandkakonyi, This looks great! Although this is a relatively small change, we've not got capacity to review, merge and release this right now. We'll try and get this reviewed and merged before Christmas. Thanks for submitting a PR, we really appreciate it 🙏 Jonathan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If the first test finishes before the socket connection is established, it never gets reported to the CLI server.
Changed
Added a temporary cache to store results until connection gets established, then send the results to the CLI server.