Quote path arguments to nrfjprog #168
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrfjprog doesn't like spaces in file paths, which makes actions like "burn bootloader" fail if you're on windows and have a space in your username. Quoting the argument fixes this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nrfjprogdoesn't like spaces in file paths, which makes actions like "burn bootloader" fail if you're on windows and have a space in your username. Quoting the argument fixes this.I looked through this file and found anywhere it looks like
nrfjprogis taking in file path arguments. There could still be other usages in other files.Help needed: I'm not actually sure how to test this PR. It looks pretty simple, but I'd be happier knowing that it works.