-
Notifications
You must be signed in to change notification settings - Fork 347
feat: adjusted available extensions #4463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Kemi-Elizabeth
wants to merge
4
commits into
main
Choose a base branch
from
4462-adminpack-extension-no-longer-supported---postgresql-update
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
e1232df
feat: adjusted available extensions
Kemi-Elizabeth dff5283
Update sites/platform/src/add-services/postgresql.md
Kemi-Elizabeth 84f67ad
Merge branch 'main' into 4462-adminpack-extension-no-longer-supported…
Kemi-Elizabeth f5ac063
Merge branch 'main' into 4462-adminpack-extension-no-longer-supported…
Kemi-Elizabeth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -757,6 +757,13 @@ For more details, see how to [upgrade to PostgreSQL 12 with `postgis`](#upgrade- | |
|
||
{{< /note >}} | ||
|
||
{{< note >}} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I worry, given the length of the extensions section, that adding the note to the bottom will be completely missed by readers. When they get to the |
||
|
||
You can't upgrade to PostgreSQL 17 with the `adminpack` extension enabled. | ||
|
||
{{< /note >}} | ||
|
||
|
||
## Notes | ||
|
||
### Could not find driver | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I worry, given the length of the extensions section, that adding the note to the bottom will be completely missed by readers. When they get to the
adminpack
extension in the list, the note is still not in the viewport.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to add how to upgrade if you have this extension, like what we're doing above for postgis.