-
Notifications
You must be signed in to change notification settings - Fork 347
Composable image: Move common content into individual settings topics #4789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
catplat
wants to merge
42
commits into
main
Choose a base branch
from
4773-move-rlnshps-content
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iding in separate files
…common properties above the properties table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
do not merge
docs rework
For issues about updating the docs to the new style and content model (see the project for more)
markdown/prose
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Feedback indicates the single-runtime image and composable image topics are too long. These two topics contains a lot of common content.
Decision: Split out the common content into separate settings topics, and keep the image-specific content in the original single-runtime image and composable image topics.
What's changed
Where are changes
Individual settings topic will eventually move to Configure apps > App reference > Image properties > .
Updates are for:
sites/platform
templates)sites/upsun
templates)