Create target test #1059
Create target test #1059
Conversation
We can use, for example: `make test package=plone.namedfile` or `make test package=plone.namedfile test=test_scaling`
| Use the `make test` target to run unit tests for a package: | ||
|
|
||
| ```bash | ||
| # Run all unit tests for a package (package is required) | ||
| make test package=plone.namedfile | ||
|
|
||
| # Run a specific test | ||
| make test package=plone.namedfile test=test_scaling |
There was a problem hiding this comment.
Use generic shell syntax highlighter, don't use comments for instructions because they are low contrast in the rendered code block, and make it easier to copy-paste a single command.
| Use the `make test` target to run unit tests for a package: | |
| ```bash | |
| # Run all unit tests for a package (package is required) | |
| make test package=plone.namedfile | |
| # Run a specific test | |
| make test package=plone.namedfile test=test_scaling | |
| Use the `make test` target to run unit tests for a package. | |
| For example, run all unit tests for a given package. | |
| ```shell | |
| make test package=plone.namedfile | |
| ``` | |
| Run a specific test in the given package. | |
| ```shell | |
| make test package=plone.namedfile test=test_scaling |
There was a problem hiding this comment.
@stevepiercy We need to specify somewhere that the package parameter is required.
There was a problem hiding this comment.
Line 135 describes how to run only one test from a given package.
What I'm trying to say is that it's not possible to execute the command:
make test
it's necessary to pass the package:
make test package=plone.namedfile
There was a problem hiding this comment.
I still don't understand what you mean. Line 135 mentions "the given package", and is followed by line 138, which has the package parameter.
There was a problem hiding this comment.
@wesleybl But the run-tests.sh script says it is supposed to be run using make test, and that made me realize you are adding a new test target even though there is already one: https://github.com/plone/buildout.coredev/blob/6.2/Makefile#L468
There was a problem hiding this comment.
Hmm, in version 6.1 it doesn't exist: https://github.com/plone/buildout.coredev/blob/6.1/Makefile
There was a problem hiding this comment.
I see, it was added in #1020
It would be nice to have it for both 6.1 and 6.2, with the same implementation in both, and improve it to have a way to optionally run the tests for only one package.
There was a problem hiding this comment.
It seems the target already accepts individual packages and tests:
https://github.com/plone/buildout.coredev/blob/6.2/Makefile#L468
I'll test it later.
There was a problem hiding this comment.
I checked and actually the target in branch 6.2 doesn't support running only the tests from a specific package.
| - Packages in development with modern layout (`src/package/src/`) | ||
| - Packages in development with legacy layout (`src/package/`) | ||
| - Packages installed in the virtual environment |
There was a problem hiding this comment.
No need to capitalize a list item when it is not a sentence.
| - Packages in development with modern layout (`src/package/src/`) | |
| - Packages in development with legacy layout (`src/package/`) | |
| - Packages installed in the virtual environment | |
| - packages in development with modern layout (`src/package/src/`) | |
| - packages in development with legacy layout (`src/package/`) | |
| - packages installed in the virtual environment |
|
|
||
| You can also run tests directly with `zope-testrunner`: | ||
|
|
||
| ```bash |
There was a problem hiding this comment.
| ```bash | |
| ```shell |
davisagli
left a comment
davisagli
left a comment
There was a problem hiding this comment.
This looks helpful for the use case of testing one package.
The main purpose of buildout.coredev is to provide a place to test all packages together. So it would be nice to also make the package parameter optional, and in that case run the tests from all packages. Then we could update the Jenkins builds to use this instead of the buildout.
@davisagli The problem is that |
|
@davisagli I see we have this list of packages to be tested for the buildout: https://github.com/plone/buildout.coredev/blob/6.2/tests.cfg#L6 Can we read from there? |
|
@wesleybl Oh, I see we already have this script to run all the tests (with the same list): https://github.com/plone/buildout.coredev/blob/6.2/run-tests.sh |
We can use, for example:
make test package=plone.namedfileor
make test package=plone.namedfile test=test_scaling