Skip to content

Adding support for bringing your own driver to the Browser #2693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Adding support for bringing your own driver to the Browser #2693

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bf0719b
Adding support for bringing your own driver to the Browser
BSd3v Nov 13, 2023
d5d816b
moving driver to be last argument to avoid use in positional arguments
BSd3v Nov 13, 2023
e2a0380
Making `implicitly_wait` the default for even with drivers
BSd3v Nov 15, 2023
83dc972
Merge branch 'dev' into patch-1
BSd3v Mar 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions dash/testing/browser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ def __init__(
percy_assets_root="",
wait_timeout=10,
pause=False,
driver=None,
):
self._browser = browser.lower()
self._remote_url = remote_url
Expand All @@ -65,8 +66,11 @@ def __init__(
self._percy_run = percy_run
self._pause = pause

self._driver = until(self.get_webdriver, timeout=1)
self._driver.implicitly_wait(2)
if driver:
self._driver = driver
else:
self._driver = until(self.get_webdriver, timeout=1)
self._driver.implicitly_wait(2)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want the implicitly_wait inside here or would it be better to always call that even if you provide your own driver?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets set the implicitly_wait(2) for all, since there is no easy way to confirm if the driver already has one set.


self._wd_wait = WebDriverWait(self.driver, wait_timeout)
self._last_ts = 0
Expand Down