Skip to content

Fix broken styling of map attributions #7526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 27, 2025
+67 −98
Merged

Fix broken styling of map attributions #7526

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a6b267
change approach for bundling maplibre css to fix formatting issue
emilykl Aug 16, 2025
c8af613
remove build step which deletes CSS files, no longer needed (thanks @…
emilykl Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions esbuild-config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
var glsl = require('esbuild-plugin-glsl').glsl;
var environmentPlugin = require('esbuild-plugin-environment').environmentPlugin;
const stylePlugin = require('esbuild-style-plugin');
const InlineCSSPlugin = require('esbuild-plugin-inline-css');

module.exports = {
entryPoints: ['./lib/index.js'],
Expand All @@ -10,7 +10,7 @@ module.exports = {
minify: false,
sourcemap: false,
plugins: [
stylePlugin(),
InlineCSSPlugin(),
glsl({
minify: true,
}),
Expand Down
149 changes: 64 additions & 85 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@
"esbuild-plugin-browserify-adapter": "^0.1.4",
"esbuild-plugin-environment": "^0.4.0",
"esbuild-plugin-glsl": "^1.2.2",
"esbuild-style-plugin": "^1.6.3",
"esbuild-plugin-inline-css": "^0.0.1",
"extra-iterable": "^2.5.22",
"falafel": "^2.2.5",
"fs-extra": "^10.1.0",
Expand Down
10 changes: 0 additions & 10 deletions tasks/util/bundle_wrapper.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,16 +46,6 @@ export default async function _bundle(pathToIndex, pathToBundle, opts, cb) {

addWrapper(pathToBundle);

if(pathToBundle.endsWith('.js')) {
var len = pathToBundle.length;
var cssOutput = pathToBundle.slice(0, len - 3) + '.css';

// remove unwanted css file
if (fs.existsSync(cssOutput)) {
fs.unlinkSync(cssOutput);
}
}

if(cb) cb();
}

Expand Down