Skip to content

Fix: Wrong Parameter for groupID replaced and removed Files Tab from Template #1083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Fix: Wrong Parameter for groupID replaced and removed Files Tab from Template #1083

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/lib/PnP.Framework/Provisioning/ObjectHandlers/ObjectTeams.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ private static JToken CreateTeamFromProvisioningSchema(PnPMonitoredScope scope,
// If security is configured, add the members and owners defined in the template to the Team
if (team.Security != null)
{
if (!SetGroupSecurity(scope, parser, team, teamId, accessToken, graphBaseUri)) return null;
if (!SetGroupSecurity(scope, parser, team, parsedGroupId, accessToken, graphBaseUri)) return null;
}

// Then promote the Group into a Team or update it, if it already exists. Patching a team doesn't return an ID, so use the parsedGroupId directly (teamId and groupId are the same).
Expand Down Expand Up @@ -1950,6 +1950,9 @@ private static List<TeamTab> GetTeamChannelTabs(ExtractConfiguration configurati
var teamTabs = teamTabsJObject.ToObject<TeamTab[]>();
foreach (var tab in teamTabs)
{
if (tab.Configuration != null && tab.ID == "3ed5b337-c2c9-4d5d-b7b4-84ff09a8fc1c") {
continue;
}
if (tab.Configuration != null && string.IsNullOrEmpty(tab.Configuration.ContentUrl))
{
tab.Configuration = null;
Expand Down