Skip to content

Adding response HTTP Version accessors to Request object #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adding response HTTP Version accessors to Request object #326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Classes/ASIHTTPRequest.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,9 +260,12 @@ typedef void (^ASIDataBlock)(NSData *data);

// HTTP status code, eg: 200 = OK, 404 = Not found etc
int responseStatusCode;

// Description of the HTTP status code
NSString *responseStatusMessage;

// HTTP Version, e.g. 1.0, 1.1 etc
NSString *responseHTTPVersion;

// Size of the response
unsigned long long contentLength;
Expand Down Expand Up @@ -944,6 +947,7 @@ typedef void (^ASIDataBlock)(NSData *data);
@property (retain) NSDictionary *proxyCredentials;
@property (assign,readonly) int responseStatusCode;
@property (retain,readonly) NSString *responseStatusMessage;
@property (retain,readonly) NSString *responseHTTPVersion;
@property (retain) NSMutableData *rawResponseData;
@property (assign) NSTimeInterval timeOutSeconds;
@property (retain, nonatomic) NSString *requestMethod;
Expand Down
6 changes: 5 additions & 1 deletion Classes/ASIHTTPRequest.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
#import "ASIDataCompressor.h"

// Automatically set on build
NSString *ASIHTTPRequestVersion = @"v1.8.1-61 2011-09-19";
NSString *ASIHTTPRequestVersion = @"v1.8.1-79 2012-05-31";

static NSString *defaultUserAgent = nil;

Expand Down Expand Up @@ -225,6 +225,7 @@ - (void)callBlock:(ASIBasicBlock)block;
@property (retain) NSString *authenticationRealm;
@property (retain) NSString *proxyAuthenticationRealm;
@property (retain) NSString *responseStatusMessage;
@property (retain) NSString *responseHTTPVersion;
@property (assign) BOOL inProgress;
@property (assign) int retryCount;
@property (assign) BOOL willRetryRequest;
Expand Down Expand Up @@ -389,6 +390,7 @@ - (void)dealloc
[PACurl release];
[clientCertificates release];
[responseStatusMessage release];
[responseHTTPVersion release];
[connectionInfo release];
[requestID release];
[dataDecompressor release];
Expand Down Expand Up @@ -2155,6 +2157,7 @@ - (void)readResponseHeaders
[self setResponseHeaders:[NSMakeCollectable(CFHTTPMessageCopyAllHeaderFields(message)) autorelease]];
[self setResponseStatusCode:(int)CFHTTPMessageGetResponseStatusCode(message)];
[self setResponseStatusMessage:[NSMakeCollectable(CFHTTPMessageCopyResponseStatusLine(message)) autorelease]];
[self setResponseHTTPVersion:[NSMakeCollectable(CFHTTPMessageCopyVersion(message)) autorelease]];

if ([self downloadCache] && ([[self downloadCache] canUseCachedDataForRequest:self])) {

Expand Down Expand Up @@ -5086,6 +5089,7 @@ - (void)setRequestRedirectedBlock:(ASIBasicBlock)aRedirectBlock
@synthesize shouldPresentProxyAuthenticationDialog;
@synthesize authenticationNeeded;
@synthesize responseStatusMessage;
@synthesize responseHTTPVersion;
@synthesize shouldPresentCredentialsBeforeChallenge;
@synthesize haveBuiltRequestHeaders;
@synthesize inProgress;
Expand Down