Skip to content

Conversation

Bidek56
Copy link
Collaborator

@Bidek56 Bidek56 commented Sep 14, 2025

Initial support for readExcel #331.
fastExcel used, which is the same Excel library as used in the main project.

@Bidek56 Bidek56 self-assigned this Sep 14, 2025
@Bidek56 Bidek56 added the enhancement New feature or request label Sep 16, 2025
@Bidek56
Copy link
Collaborator Author

Bidek56 commented Sep 16, 2025

After adding fastexcel crate, nodejs-polars.darwin-arm64.node file size goes from 66Mbs to 79Mbs.
I am hesitant on adding the fastexcel dependency. @universalmind303 what do you think? thx

@universalmind303
Copy link
Collaborator

@Bidek56 yeah, that's a pretty big increase! what I would prefer is if there was a way to make it an optional dependency, but that's pretty tricky with napi.

Alternatively, we could do it all on the js side of things. Have the read_excel function in JS create some arrow arrays. Then you can zero copy those into rust.

@Bidek56
Copy link
Collaborator Author

Bidek56 commented Sep 18, 2025

@Bidek56 yeah, that's a pretty big increase! what I would prefer is if there was a way to make it an optional dependency, but that's pretty tricky with napi.

Alternatively, we could do it all on the js side of things. Have the read_excel function in JS create some arrow arrays. Then you can zero copy those into rust.

yes, but the Excel JS packages are either not maintained, like exceljs or SheetJS, which isn’t fully open source.

@Bidek56
Copy link
Collaborator Author

Bidek56 commented Sep 18, 2025

read-excel-file is maintained and popular but I rather use a package which is used by the main repo like fastexcel

@Bidek56
Copy link
Collaborator Author

Bidek56 commented Sep 19, 2025

Closing due to increase in .node file size.

@Bidek56 Bidek56 closed this Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants