Skip to content

[:coffin:] Refactoring return values #1209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JJ merged 5 commits into from
Oct 18, 2022
Merged

[:coffin:] Refactoring return values #1209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a019fec
:coffin: result of this is never used
Oct 10, 2022
cc9ce28
No need to await a const
Oct 10, 2022
21c56ba
Does not return anything
Oct 10, 2022
4c00e86
Merge branch 'main' into ♻-PROD4POD-1930-refreshFiles
Oct 17, 2022
fff0b9c
Address comments
Oct 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion feature-utils/poly-import/src/storage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ export class FeatureFileStorage {
statResults[file.id] = await polyOut.stat(file.id);
}
this._files = statResults;
return files;
}

async readFile(path) {
Expand Down
12 changes: 3 additions & 9 deletions feature-utils/poly-look/src/react-components/contexts/poly-import.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,11 @@ export const PolyImportProvider = ({
storage
.refreshFiles()
.then(async () => {
const resolvedFiles = [];
if (!storage.files) {
setFiles(null);
return;
}
for (const file of storage.files) {
resolvedFiles.push(await file);
}
const resolvedFiles = await Promise.all(storage.files);
setFiles(resolvedFiles);
setIsLoading(false);
})
Expand All @@ -54,11 +51,8 @@ export const PolyImportProvider = ({
useEffect(() => {
if (!pod) return;
const storage = new FeatureFileStorage(pod, async () => {
const resolvedFiles = [];
for (const file of storage.files) {
resolvedFiles.push(await file);
}
setFiles(Object.values(resolvedFiles));
const resolvedFiles = await Promise.all(storage.files);
setFiles(resolvedFiles);
});
setStorage(storage);
}, [pod]);
Expand Down