WIP stack: Update previous_keyboard only when enter() is called
#1168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempt at fixing #1129. This does seem to fix that issue with the reproduction steps listed there, but I still see it if I create a stack with a terminal and firefox, focus the terminal (element index 0 in the stack) and close it, then try to type in firefox (now element index 0). So managing what child has keyboard focus still needs some work. I'm not sure exactly what conditions apply were I've randomly seen this behavior in actual use (and if this particular change helps) or if this could cause problems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt at fixing #1129.
This does seem to fix that issue with the reproduction steps listed there, but I still see it if I create a stack with a terminal and firefox, focus the terminal (element index 0 in the stack) and close it, then try to type in firefox (now element index 0).
So managing what child has keyboard focus still needs some work. I'm not sure exactly what conditions apply were I've randomly seen this behavior in actual use (and if this particular change helps) or if this could cause problems.