WIP Don't add focus indicator to another floating window when a floating window is dragged #1687
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been annoying me when using floating windows. Colored indicators appearing where they shouldn't (and don't with tiling drags) is a bit distracting.
This fix seems to work on a single output, but with multiple outputs messes up the focus indicators on the other output. Since the floating layout (but not the tiling layout) can show focus indicators on multiple outputs, and we only want to omit it on the output we drag a window from.
I thought modifying
refresh_focus_stack
not to remove a window from the stack if it in theSeatMoveGrabState
might work, but it seemsappend_focus_stack
is being called when the move grab starts? (Inset_focus
, called byprocess_input_event
).