Add support for determining the right Linux binary URL for Pop!_OS #915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is a simple fix that ensures we can generate the right Linux binary URLs for Pop!_OS users. Pop OS is a fairly popular desktop distro that is binary-compatible with Ubuntu, so e.g. `jammy` binaries work out of the box. We never had to worry about detecting this distro for Workbench because it's desktop-only, but it's nice to wire things up in Ark to benefit desktop Positron users (like me!) on Pop OS. Signed-off-by: Aaron Jacobs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is a simple fix that ensures we can generate the right Linux binary URLs for Pop!_OS users.
Pop OS is a fairly popular desktop distro that is binary-compatible with Ubuntu, so e.g.
jammybinaries from Public Package Manager work out of the box.We never had to worry about detecting this distro for Workbench because it's desktop-only, but it's nice to wire things up in Ark to benefit desktop Positron users (like me!) on this distro.